Repository navigation
FRLG BagDetector: scroll arrow fix and tests - #1771
Merged
theastrogoth merged 8 commits intoOct 31, 2026
Merged
theastrogoth merged 8 commits into
theastrogoth merged 8 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
marked this pull request as ready for review
October 31, 2026 00:12
Comment on lines
+50
to
+52
| // Scrolled down: a bag, but a red up-arrow covers the middle of the top | ||
| // frame, and the detector's strip there runs under it, so it reads no bag. | ||
| database.add<Test_BagDetector>("PokemonFRLG/Bag/Items_Scrolled.png", false); |
Contributor
There was a problem hiding this comment.
Should we fix the detector's behavior now and flip this to true? I'd be fine with shortening the stripe along the top to avoid the issue mentioned here.
Contributor
Author
There was a problem hiding this comment.
yeh added it in - was gonna keep it separate to showcase the current behavior clearly
The red up-arrow drawn over the bag's top frame once the pocket list is scrolled made the check fail, so a scrolled bag read as no bag. The strip now stops short of it, and the scrolled test expects a bag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…with no bag Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Register the tests in the detector's own files, as the other FRLG detectors do, and drop the negative controls that read images from other detectors' directories (Party/Party_1.png, Box/BoxSelection_White.png). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
…ector tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
theastrogoth
changed the title
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds screenshot tests for FRLG's
BagDetector, which had none, pinning down what it does today.PokemonFRLG/Bag/).Testing
🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E