Repository navigation
Rename AudioInfo.h/.cpp to AudioFormat.h/.cpp - #1782
Merged
Merged
Conversation
The file now only holds the AudioSampleFormat alias, sample_size / sample_format_of and the AudioFormat class, so name it after that class. Updates the include guard, the file header comments, all includes of the header, and the SourceFiles.cmake entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the
AudioDeviceInfo(#1779) andAudioInputChoice(#1781) splits,AudioInfo.h/.cpponly holds theAudioSampleFormatalias,sample_size/sample_format_ofand theAudioFormatclass — so name it after that class.git mvboth files (rename detected: .h 83% / .cpp 93% similarity).PokemonAutomation_AudioPipeline_AudioInfo_H→..._AudioFormat_H; file header comments → "Audio Format".AudioInputChoice.h,AudioPassthroughPair.h,AudioSource.h, the IO/ and Backends/ headers +AudioInputFile.cpp,SinkPipeline_Tests.cpp,AudioInfo_Tests.cpp,Recording/StreamHistorySession.cpp) and theSourceFiles.cmakeentries.14 files changed, +18/−18. Builds clean;
pa-testpasses (20,150 passed, 0 failed).