Repository navigation
Tests: report the fault address and thread in the crash backtrace - #1823
Merged
Merged
Conversation
When the runner dies on SIGSEGV/SIGBUS, the signal's faulting address (si_addr) tells us which memory region the bad pointer landed in (stack, heap, a library), which narrows the corruption source far more than the backtrace alone. The handler is now installed with sigaction()/SA_SIGINFO and prints the signal number, the faulting address (for SIGSEGV/SIGBUS), and the crashing thread's id on the [PA-CRASH] line.
Refactor of the fault-address addition: all the Apple/Linux backtrace and signal-handler code now lives in CommonFramework/ErrorReports/CrashBacktrace.h/.cpp, next to the existing Windows crash handling (ProgramDumper), following its structure (platform split in the .cpp, no-op on the other side). CommandLineTests.cpp just includes the header and calls install_crash_backtrace_handlers().
pa-devbot
force-pushed
the
tests-crash-fault-address
branch
from
November 1, 2026 20:33
f7e0e64 to
e44318c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #1819, for the Mac Intel crash investigation.
Part 1 — fault address + thread id. When the runner dies on SIGSEGV/SIGBUS, the signal's faulting address (
si_addr) tells us which memory region the bad pointer landed in — stack, heap, or a library — which narrows the corruption source far more than the backtrace alone. The handler is now installed withsigaction()/SA_SIGINFOand the[PA-CRASH]line becomes:Part 2 — refactor into ErrorReports/. All the Apple/Linux backtrace/signal-handler code moved out of
CommandLineTests.cppintoCommonFramework/ErrorReports/CrashBacktrace.h/.cpp, next to the existing Windows crash handling (ProgramDumper), following its structure: platform split in the.cpp, no-op on the other side.CommandLineTests.cppjust includes the header and callsinstall_crash_backtrace_handlers().Verified locally with a forced SIGSEGV: the line, the backtrace, and the 139 exit code all still come through.