Repository navigation
Conversation
Run the existing test database through a dedicated QCoreApplication executable with isolated logs and no settings or device scans. Support name filters and listing while preserving the GUI test mode exit status. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
dayfine
changed the title
dayfine
marked this pull request as ready for review
November 4, 2026 04:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a dedicated unit-test executable that can run while SerialPrograms is controlling a console. It uses
QCoreApplication, skips settings and device discovery, and writes to its own log folder.SerialProgramsTestsis built by default (-DTEST_RUNNER_EXE=OFFdisables it). Repeated--filter <text>arguments select tests by name substring;--listlists the selection. Exit status is the failure count capped at 254, or 255 for bad arguments/no matches. The existing GUI test mode keeps its 0/1 exit status. This improves the test-running workflow; both executables still build the same library.How to review
Read the new
TestRunner_Main.cppandTestRunnerExecutable.cmake, then the filter/count changes inComputerPrograms_UnitTestRunnerand the command-line test wrapper. The existing test execution remains in the library; startup and shutdown for the new executable are new. The prerequisiteuse_qt_ui()change is already merged as #1843.