Ignore native frames in third-party exception filter - #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The third-party exception filter retained Klaviyo chunk load errors when their stack included a native
Array.reduceframe. Ignore frames withfilename: '<anonymous>'andin_app: falsewhen no conflicting source is present, so the reported five-vendor-frame plus one-native-frame stack is suppressed.Each exception in the cause chain must still contain at least one identified third-party frame, and all remaining frames must be third party. First-party, unknown-origin, missing, and native-only stacks remain visible.
Validation: the chunk 7130 regression failed before the fix and passes afterward. Added coverage for native-only stacks, mixed first-party/unknown frames, and exception causes.
npm run test:allpasses all 277 tests;node --check analytics.jsandgit diff --checkpass.