fix(tests): un-nest AudioMetaUtilsTest — the whole class never ran - #30
Merged
Merged
Conversation
A bad paste/merge left mimeTypeToFormat_mapsUniversalFormats defined three times, two of them as local functions nested inside the other two @test methods. Braces were balanced so it compiled, but a local function annotated @test compiles to a synthetic exterior$interior method that JUnit4's runner rejects, taking the whole class down with InvalidTestClassError. Un-nests the three functions back to class level. No assertion changed: verified all 16 by hand against the current mimeTypeToFormat() — they were already correct, just never executed. mimeTypeToFormat() had zero coverage; now it has 3 passing tests, exercised for the first time. check-baseline.sh / BASELINE-TESTS.md updated to drop this from the known-failures list (local docs, gitignored — not part of this diff).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staged internally first (was chore/p7-fix-audiometautilstest on PixelPlayerHQ#2821, closed — see that PR's closing comment). Will be proposed upstream again once the downloads feature it's part of is further along.