Popalay/offline data - #99
Merged
Merged
Conversation
…re, architecture, key dependencies, build setup, and coding conventions.
- Bump AGP to 8.9.1, compileSdk/targetSdk to 36, Gradle wrapper to 8.11.1 - Upgrade Kotlin to 2.0.21 with Compose Multiplatform plugin, Compose to 1.6.11 - Set JVM toolchain to 21 across all modules - Upgrade Voyager to 1.1.0-beta02 to fix AndroidScreenLifecycleOwner lifecycle crash on back navigation; update NavigatorSaver lambda signature accordingly - Upgrade Koin to 3.5.6 to match koin-compose 1.0.4 (binary-incompatible with 3.4.x) - Downgrade Kermit logger to 2.0.6 (compatible with Kotlin 2.0.x); fix Logger call-site overload ambiguity - Fix StateMachine initialization NPE by introducing backing MutableStateFlow; use tryEmit with extraBufferCapacity=64 to prevent dropped actions after back navigation - Replace custom AppBottomSheetNavigator to avoid removed ModalBottomSheetLayout API - Give image loader its own plain HttpClient to avoid ContentNegotiation sending Accept: application/json on image requests (HTTP 406) - Simplify AsyncImage: remove BoxWithConstraints and placeholder logic now that ExternalImageUrl.scaledUrl returns the plain URL - Update CI workflows to actions/checkout@v4 and setup-java@v4 with Zulu JDK 21 Made-with: Cursor
- Bundle cocktails.json (426 drinks) as an Android asset and commonMain resource - Add LocalDrinkDataSource backed by the bundled JSON, replacing the remote Api client - Add CocktailDbDrink DTO and CocktailDbMapper to convert to domain Drink model - Add expect/actual ResourceReader for reading bundled assets on Android and iOS - Update DrinkRepository and CollectionRepository to use LocalDrinkDataSource - Remove deprecated Api.kt remote client and DrinksResponse/DrinkListFirstElementTransformer - Add scripts/download_cocktails.py for re-fetching and preprocessing the dataset Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.