Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/mw-dev/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -839,6 +839,12 @@ The former `posthog_frozen_perf_trino_cached` selection has been removed; use
`posthog_frozen_perf` instead. Omit the workflow's `duckgres_image` override so the
control-plane build explicitly persists the expected baseline cache setting.

This experimental branch enables `optimizer.dictionary-aggregation=true` in
the isolated Trino coordinator and worker configurations. The shared fixture
template also applies this setting to isolated Trino E2E clusters. Production
configuration is managed separately. For an off/on benchmark, use the same
digest-pinned Trino image and the full query corpus in both runs.

For local invocation, set `SCENARIO_NAME=posthog_frozen_perf` and `E2E_SUITE=trino`
before both `tests/mw-dev/run.sh deploy` and `test-scenario`. Use the existing lane
credentials, images, and namespace requirements. The harness starts three Trino
Expand Down
2 changes: 2 additions & 0 deletions tests/mw-dev/manifests.trino.tmpl.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ data:
cache-manager.name=memory
config.properties: |
coordinator=true
optimizer.dictionary-aggregation=true
node-scheduler.include-coordinator=false
http-server.http.port=8080
http-server.https.enabled=true
Expand Down Expand Up @@ -174,6 +175,7 @@ data:
cache-manager.name=memory
config.properties: |
coordinator=false
optimizer.dictionary-aggregation=true
http-server.http.port=8080
discovery.uri=http://duckgres-trino.${NAMESPACE}.svc:8080
query.max-memory=${TRINO_QUERY_MEMORY}
Expand Down
2 changes: 1 addition & 1 deletion tests/mw-dev/run_sh_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ func TestTrinoWorkersMatchDuckgresAggregateCompute(t *testing.T) {
}
data := manifest["data"].(map[string]any)
config := data["config.properties"].(string)
for _, want := range []string{"query.max-memory=6GB", "query.max-memory-per-node=" + expectedPerNode} {
for _, want := range []string{"query.max-memory=6GB", "query.max-memory-per-node=" + expectedPerNode, "optimizer.dictionary-aggregation=true"} {
if !strings.Contains(config, want) {
t.Errorf("Trino %s config missing %q:\n%s", name, want, config)
}
Expand Down
Loading