This repository was archived by the owner on Oct 8, 2026. It is now read-only.
Repository navigation
fix(scenario): read Trino endpoint from status.connection - #1247
Merged
Merged
Conversation
#1246 removed cell.coordinator_url from GET /api/v1/orgs/:id/trino; pooled cells advertise their client endpoint (the Gateway) as status.connection instead. The scenario perf step still required the removed field, so the nightly posthog_frozen_perf run failed at perf_queries with "has no coordinator URL" even though the stack was healthy. Build the Trino server URL from status.connection host/port, the same source tests/mw-dev/e2e/trino.sh already uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The nightly
scenario-dev/posthog_frozen_perfrun failed (run 36837715683) atperf_queries:The stack was healthy: provisioning,
wait_trino_ready, SQL setup and Hoglake setup all passed. #1246 removedcell.coordinator_urlfromGET /api/v1/orgs/:id/trino. Pooled cells advertise their client endpoint (the Gateway) asstatus.connectioninstead. The scenario runner still required the removed field, sostatus.Cell.CoordinatorURLwas always empty. The last green run was on7cb596fc; the first red one is onfe14612b(#1246).Fix
provision.TrinoStatusmirrors the current API: removescell.coordinator_urland decodesstatus.connection.perf_queriesbuilds the Trino server URL ashttps://<host>:<port>fromstatus.connection, the same sourcetests/mw-dev/e2e/trino.shalready uses. A missing connection fails with a clearstatus.connectionerror.tests/mw-dev/README.mdno longer documentscell.coordinator_url.wait_trino_readyis deliberately unchanged. The admin API derivesstatus.connectionfrom the same conditionstrinoReadyalready checks, plus root's password hash, which doesn't change during the wait. Waiting on the connection would turn an immediate, precise error into a 15-minute generic timeout.In this scenario the
trinoandtrino_cachedtargets still run against the isolated perf and cached Trino instances. The gateway address only feedsprepareBenchmarkCatalog's check that the benchmark doesn't reuse the tenant's Trino, and that check still holds.Known gap (not addressed)
The Trino username is still
status.principal, notstatus.connection.username. These differ only when a cell'sclient_urluses the{database_name}per-org host, which the mw-dev pool fixture doesn't. Fixing it properly means a different username per target, because the isolated perf/cached Trino instances need the principal.Testing
go test ./tests/mw-dev/... ./tests/perf/publishercli(the workflow's own gate) passes.scenario-devdispatch against this branch is the end-to-end check.🤖 Generated with Claude Code