This repository was archived by the owner on Oct 8, 2026. It is now read-only.
Repository navigation
fix(trino): validate service authentication during pool readiness - #1249
Merged
Merged
Conversation
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trino pools with service authentication cannot certify coordinators because readiness treats every password authenticator as a replicated password file.
PREPARING, allowing later probes to succeed before recording an admission receipt.Before:
After:
Validation
just test-trino.just lint, shell syntax, and Kubernetes lint for changed code passed. Full Kubernetes lint reports existing baseline findings.Deployment
Deploy all Duckgres controllers before Trino #99. The callback proves endpoint reachability and pool-token acceptance; tenant-grant smoke tests remain necessary.
Existing
VALIDATINGreceipts remain immutable and may need separate guarded recovery. This PR changes no UI.🤖 Agent context
Codex (GPT-6) implemented and reviewed this change with delegated agents. Skills: writing-pr-descriptions and signed-git-publish. No production changes were made.