Skip to content

ci: remove unused release workflow permissions - #205

Merged
marandaneto merged 2 commits into
mainfrom
ci/remove-unused-workflow-permissions-20260910104257
Sep 10, 2026
Merged

marandaneto merged 2 commits into
mainfrom
ci/remove-unused-workflow-permissions-20260910104257

Conversation

@marandaneto

Copy link
Copy Markdown
Member

💡 Motivation and Context

The release job has Actions write and OIDC permissions without a corresponding operation.

Remove actions: write and id-token: write from the release job. Keep contents: write for GitHub release creation. Hex and GitHub App authentication stay unchanged.

This follows the permissions audit prompted by PostHog/posthog-js#4889. Read-only workflow defaults are unchanged. This does not change build/publish isolation or restrict separate GitHub App tokens.

💚 How did you test it?

  • Actionlint passed for the original and updated release workflow.
  • Parsed the original and updated YAML and verified that only the listed permission keys changed. Triggers, steps and job dependencies are unchanged.
  • git diff --check passed.
  • Reviewed the pinned action contracts and retained the permissions used by the release steps. No live release was run.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes. No SDK tests apply to this permissions-only change.
  • I updated the docs if needed. No documentation change is needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

No package release or changeset is needed.

🤖 Agent context

Autonomy: Human-driven (agent-assisted)

Implemented with Pi and delegate agents using file tools, Git, GitHub CLI, Python/PyYAML and actionlint. The parent agent reviewed the final diff. Work was limited to removing unused workflow permissions in a dedicated worktree. Autoreview was skipped because this diff contains only GitHub workflow permission administration. No session transcript was published. Human review is required.

@marandaneto marandaneto self-assigned this Sep 10, 2026
@marandaneto
marandaneto marked this pull request as ready for review September 10, 2026 08:50
@marandaneto
marandaneto requested a review from a team as a code owner September 10, 2026 08:50
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

posthog-elixir Compliance Report

Date: 2026-09-10 12:37:18 UTC
Duration: 117690ms

✅ All Tests Passed!

46/46 tests passed


Capture Tests

29/29 tests passed

View Details
Test Status Duration
Format Validation.Event Has Required Fields 610ms
Format Validation.Event Has Uuid 611ms
Format Validation.Event Has Lib Properties 610ms
Format Validation.Distinct Id Is String 609ms
Format Validation.Token Is Present 610ms
Format Validation.Custom Properties Preserved 610ms
Format Validation.Event Has Timestamp 610ms
Retry Behavior.Retries On 503 5616ms
Retry Behavior.Does Not Retry On 400 2613ms
Retry Behavior.Does Not Retry On 401 2613ms
Retry Behavior.Respects Retry After Header 5616ms
Retry Behavior.Implements Backoff 15626ms
Retry Behavior.Retries On 500 5616ms
Retry Behavior.Retries On 502 5614ms
Retry Behavior.Retries On 504 5616ms
Retry Behavior.Max Retries Respected 15627ms
Deduplication.Generates Unique Uuids 622ms
Deduplication.Preserves Uuid On Retry 5616ms
Deduplication.Preserves Uuid And Timestamp On Retry 10622ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 5615ms
Deduplication.No Duplicate Events In Batch 617ms
Deduplication.Different Events Have Different Uuids 612ms
Compression.Sends Gzip When Enabled 610ms
Batch Format.Uses Proper Batch Structure 610ms
Batch Format.Flush With No Events Sends Nothing 607ms
Batch Format.Multiple Events Batched Together 615ms
Error Handling.Does Not Retry On 403 2613ms
Error Handling.Does Not Retry On 413 2613ms
Error Handling.Retries On 408 5615ms

Feature_Flags Tests

17/17 tests passed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 610ms
Request Payload.Flags Request Uses V2 Query Param 610ms
Request Payload.Flags Request Hits Flags Path Not Decide 611ms
Request Payload.Flags Request Omits Authorization Header 610ms
Request Payload.Token In Flags Body Matches Init 610ms
Request Payload.Groups Round Trip 610ms
Request Payload.Groups Default To Empty Object 610ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False 610ms
Request Payload.Disable Geoip Omitted Defaults To False 610ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key 609ms
Request Lifecycle.No Flags Request On Init Alone 4ms
Request Lifecycle.No Flags Request On Normal Capture 610ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests 1215ms
Request Lifecycle.Mock Response Value Is Returned To Caller 609ms
Retry Behavior.Retries Flags On 502 912ms
Retry Behavior.Retries Flags On 504 913ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event 1213ms

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown

Reviews (1): Last reviewed commit: "ci: remove unused release workflow permi..." | Re-trigger Greptile

@marandaneto
marandaneto merged commit f5b23c9 into main Sep 10, 2026
29 checks passed
@marandaneto
marandaneto deleted the ci/remove-unused-workflow-permissions-20260910104257 branch September 10, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants