fix(flags): use device ID in local evaluation - #818
Open
marandaneto wants to merge 1 commit into
Open
Conversation
Contributor
posthog-python Compliance ReportDate: 2026-07-30 14:52:28 UTC ✅ All Tests Passed!111/111 tests passed Capture_V1 Tests✅ 94/94 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
marandaneto
marked this pull request as ready for review
July 31, 2026 07:23
Contributor
|
Reviews (1): Last reviewed commit: "fix(flags): use device ID in local evalu..." | Re-trigger Greptile |
ioannisj
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Local
evaluate_flags()accepted an explicit or context-derived device ID but did not forward it to bulk local evaluation. Flags usingdevice_idas their bucketing identifier could therefore disappear in local-only mode or unnecessarily fall back to a network request.This forwards the resolved device ID through the local evaluation path so device-bucketed flags produce the expected result without a remote call.
💚 How did you test it?
📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi workers implemented and independently autoreviewed this targeted fix under human direction. The final tests use deterministic opposite device buckets to demonstrate that local evaluation uses the device ID rather than the person distinct ID.