Add CLAUDE.md rules to improve Claude Code Review effectiveness - #48
Closed
jnasbyupgrade wants to merge 2 commits into
Closed
Add CLAUDE.md rules to improve Claude Code Review effectiveness#48jnasbyupgrade wants to merge 2 commits into
jnasbyupgrade wants to merge 2 commits into
Conversation
The code-review plugin's compliance agents only enforce what CLAUDE.md states explicitly and quotably, scoped to CLAUDE.md files sharing a path with the changed files. It has no other repo-local config file. Adds concrete, quotable rules targeting the classes of bugs a recent CodeRabbit pass caught that the automated review missed in a SKILL.md rewrite: self-contradicting instructions after a late-stage section rewrite, skill steps that silently contradict this repo's own CLAUDE.md policies, undefined yes/no branches, bad markdown fences, and bats tests deriving new paths instead of reusing existing helpers like PGXNREPO. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…or steps The code-review plugin's compliance agents only see the diff — they can't verify that a process step (re-reading a file, running a linter) happened during authoring. Lead each rule with a declarative "must/must not" statement checkable directly from the doc's content, keeping the authoring-workflow advice as secondary framing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Claude Code ReviewCI missed entirely.anthropics/claude-code'scode-reviewplugin, whose compliance agents only enforce rules stated explicitly and quotably inCLAUDE.md(root, plus anyCLAUDE.mdsharing a path with the changed files) — there's no other repo-local config file it reads.## Skill and Process Doc Qualitysection plus a testing-side rule, phrased as concrete, quotablemust/neverstatements targeting the specific failure classes that were missed: self-contradicting doc rewrites, skill steps silently violating this repo's own CLAUDE.md policies, undefined yes/no branches, bad markdown fences, and bats tests deriving new paths instead of reusing existing helpers (e.g.PGXNREPO).Test plan
CLAUDE.md, no code/test behavior affected.🤖 Generated with Claude Code