Remove the stale compatibility sentence from the README contributing section - #184
Merged
Merged
Conversation
The module declares 8.2.0 as its minimum in ps_versions_compliancy, and the Compatibility section above already says so. This leftover line said 1.7.7, and a compatibility statement does not belong in the contributing rules anyway.
jolelievre
approved these changes
Aug 28, 2026
ps-jarvis
added
the
Waiting for QA
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibilitysection correctly says8.2.0or later, while a leftover line further down, in the middle of the contributing rules, still claims compatibility with PrestaShop 1.7.7 and newer. That line is both wrong and misplaced, a compatibility statement does not belong in the contributing section, so it is removed rather than corrected.