pc: remove duplicate DolphinsGrace effect and fix BadOmen id (1.14.4-1.16.1) - #1236
Open
AnonymoDGH wants to merge 1 commit into
Open
pc: remove duplicate DolphinsGrace effect and fix BadOmen id (1.14.4-1.16.1)#1236AnonymoDGH wants to merge 1 commit into
AnonymoDGH wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #529
The effects.json for 1.14.4, 1.15.2 and 1.16.1 contained a duplicate
DolphinsGraceat id 31, which pushedBadOmenonto id 32 where it collided withHeroOfTheVillage.Correct registry (matching 1.17):
Verified: after the fix all three versions have 32 entries, no duplicate names, no duplicate ids, and the tail registry is
30=DolphinsGrace, 31=BadOmen, 32=HeroOfTheVillageexactly as in 1.17.