Fix packet_enchant_item enchantment field type for 1.21.11 - #1255
Open
reallyoldfogie wants to merge 1 commit into
Open
Fix packet_enchant_item enchantment field type for 1.21.11#1255reallyoldfogie wants to merge 1 commit into
reallyoldfogie wants to merge 1 commit into
Conversation
The enchantment (button ID) field in packet_enchant_item was declared as i8 for 1.21.11 only, an isolated regression relative to every other version (1.21.1-1.21.9, and later 26.1), all of which declare it as varint. Confirmed against 1.21.11's own decompiled source: net/minecraft/network/packet/c2s/play/ButtonClickC2SPacket.java encodes buttonId with PacketCodecs.VAR_INT, matching every other checked version. There was no real protocol change here. Regenerated protocol.json via tools/js (npm run build) and verified with npm run test (1849 passing, 1 pending, 0 failures).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The enchantment (button ID) field in packet_enchant_item was declared as i8 for 1.21.11 only, an isolated regression relative to every other version (1.21.1-1.21.9, and later 26.1), all of which declare it as varint.
Confirmed against 1.21.11's own decompiled source: net/minecraft/network/packet/c2s/play/ButtonClickC2SPacket.java encodes buttonId with PacketCodecs.VAR_INT, matching every other checked version. There was no real protocol change here.