Skip to content

Update hub python client for hub v0.13.0 - #209

Merged
brucetony merged 10 commits into
mainfrom
build-update
Aug 8, 2026
Merged

Update hub python client for hub v0.13.0#209
brucetony merged 10 commits into
mainfrom
build-update

Conversation

@brucetony

@brucetony brucetony commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes

    • Improved Hub node lookups with updated filter parameters.
    • Added clearer handling for missing or ambiguous node information while preserving fallback behavior.
    • Updated project and analysis node queries for improved reliability.
    • Standardized Hub responses to use consistent field names.
  • Chores

    • Updated the Flame Hub client dependency to version 0.5.3 for improved compatibility and access to the latest updates.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 10b7d158-3982-4510-aa06-bfb8f27273b8

📥 Commits

Reviewing files that changed from the base of the PR and between 4a18d92 and 96b9afc.

📒 Files selected for processing (2)
  • hub_adapter/dependencies.py
  • tests/router_tests/test_health.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • hub_adapter/dependencies.py

📝 Walkthrough

Walkthrough

The project updates flame-hub-client from 0.4.1 to 0.5.3. Hub node lookups use clientId and nodeId. Hub routes return field names instead of aliases. Node lookup logging now distinguishes multiple and missing results. The broker health-check test expects /actuator/health.

Changes

Hub client compatibility

Layer / File(s) Summary
Update flame-hub-client requirement
pyproject.toml
The dependency requirement changes from 0.4.1 to 0.5.3.
Align Hub node lookups
hub_adapter/dependencies.py
Node lookups use clientId. Multiple results log an error. Missing results log an informational message. The fallback node ID remains unchanged.
Align Hub route responses and filters
hub_adapter/routers/hub.py
Hub routes disable response-model alias serialization. Project-node and analysis-node filters use nodeId.
Update broker health-check expectation
tests/router_tests/test_health.py
The test expects the broker probe URL to use /actuator/health instead of /health.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: updating the Hub Python client and related compatibility changes for Hub v0.13.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch build-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@hub_adapter/dependencies.py`:
- Around line 276-278: Update the node lookup handling around the visible
logger.error call so an empty Hub result logs at info while preserving the
intentional nothingFound fallback; keep error-level logging for multiple
matches, using the response cardinality to distinguish the cases.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 59162977-1302-4b9b-9697-98be51498db7

📥 Commits

Reviewing files that changed from the base of the PR and between 6df94ed and 6bee074.

📒 Files selected for processing (2)
  • hub_adapter/dependencies.py
  • hub_adapter/routers/hub.py

Comment thread hub_adapter/dependencies.py
@brucetony
brucetony merged commit 075ce30 into main Aug 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant