Repository navigation
fix: apply current migrations in e2e jobs - #79
Merged
Merged
Conversation
pnpm run setup resets the database to committed migrations only, so e2e ran against a schema without migrations/current/. Any PR whose frontend queries a field added there failed every spec with a GraphQL 400. Run watch --once after setup in each e2e job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
📦 Next.js Bundle Analysis for @app/clientThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm run setupresets the database withgraphile-migrate reset, which applies committed migrations only. The e2e jobs therefore ran against a schema withoutmigrations/current/, so any PR whose frontend queries a field added there failed nearly every spec with a GraphQL 400 (Cannot query field "highlightText" on type "Event"on feat/nattitapahtuma,registrationProfile/prefillon feat/prefill). Unit tests were unaffected because their setup appliescurrent/itself.Run
pnpm --filter @app/db run watch --onceafter setup in all three e2e jobs so the e2e database matches whatpnpm devgives locally.🤖 Generated with Claude Code