Repository navigation
Lint staged files on commit and skip e2e on docs-only PRs - #82
Open
ccruzkauppila wants to merge 2 commits into
Open
ccruzkauppila wants to merge 2 commits into
ccruzkauppila wants to merge 2 commits into
Conversation
Add husky and lint-staged so a pre-commit hook runs eslint --fix and prettier --write on staged files. Add a paths-filter job to the pipeline so pull requests that only touch Markdown or docs/ skip the e2e suite; the all-checks gate accepts a skipped e2e only in that case. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019vExrP5TeAmorht8FsXsZh
📦 Next.js Bundle Analysis for @app/clientThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
pnpm prune --prod in the Docker build runs the prepare script after dev dependencies are removed, so husky isn't on the PATH there. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019vExrP5TeAmorht8FsXsZh
📦 Next.js Bundle Analysis for @app/clientThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
ccruzkauppila
marked this pull request as ready for review
October 19, 2026 18:28
ccruzkauppila
changed the base branch from
main
to
ilmo-hackathon-consolidation
November 20, 2026 14:48
ccruzkauppila
added a commit
that referenced
this pull request
Nov 20, 2026
Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0156kYgzTdmw7ZBY2vrLwQmA
4 of 7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Charlie · project thread
Before: nothing checked files before a commit, so formatting and lint problems only surfaced when CI failed. Every PR also ran the full Cypress e2e suite, even PRs that only changed Markdown.
After:
git commitrunseslint --fixandprettier --writeon the staged files only. PRs that only touch**/*.mdordocs/**skip e2e, and "All checks passed" still goes green for them.How:
huskyandlint-staged, with"prepare": "husky || true"so thatpnpm installinstalls the hook. The|| truekeeps installs working where husky isn't present: the Docker build'spnpm prune --prodrunsprepareafter dev dependencies are removed. Husky's docs suggest this.Detect changesjob (dorny/paths-filter@v4) that only runs on pull requests. Pushes to main and manual runs always run e2e, so deploys stay fully gated.all-checksnow requireschangesandcito pass. It accepts a skipped e2e only when the PR is docs-only.--no-verify.On a commit with 2 changed files, the hook takes about 6 seconds.
🤖 Generated with Claude Code
https://claude.ai/code/session_019vExrP5TeAmorht8FsXsZh