fix: expand disposable email domain blocklist - #496
Merged
ProdigyV21 merged 1 commit intoJul 28, 2026
Merged
Conversation
Contributor
Author
|
Thank you for merging the blocklist expansion. Appreciate you taking it with the existing normalization and validation order preserved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the existing exact-match
blockedDomainsset with the disposable domains enumerated by the issue, preserving normalization, validation order, error resources, and the current suffix checks. Add a focusedAuthEmailValidatorTestthat exercises the expanded set through the publicvalidateAPI instead of exposing or testing the private collection directly.AuthEmailValidatorcurrently rejects only 12 reserved or disposable domains, so the widely used throwaway providers identified in issue #368 pass Android-side account-creation validation. The currentmainclone confirms that the reported domains are absent fromblockedDomains.Happy path: each newly added disposable domain in a syntactically valid email returns
R.string.auth_email_real_requiredunder the default account-creation behavior, while a normal public email domain remains accepted; Edge cases: mixed-case and surrounding-whitespace variants normalize to a newly blocked domain, and an existing blocked domain remains rejected so the expansion does not regress current coverage.Fixes #368