Skip to content

fix: expand disposable email domain blocklist - #496

Merged
ProdigyV21 merged 1 commit into
ProdigyV21:mainfrom
mvanhorn:fix/368-bug-authemailvalidator-blocklist-missing-widely
Jul 28, 2026
Merged

fix: expand disposable email domain blocklist#496
ProdigyV21 merged 1 commit into
ProdigyV21:mainfrom
mvanhorn:fix/368-bug-authemailvalidator-blocklist-missing-widely

Conversation

@mvanhorn

Copy link
Copy Markdown
Contributor

Extend the existing exact-match blockedDomains set with the disposable domains enumerated by the issue, preserving normalization, validation order, error resources, and the current suffix checks. Add a focused AuthEmailValidatorTest that exercises the expanded set through the public validate API instead of exposing or testing the private collection directly. AuthEmailValidator currently rejects only 12 reserved or disposable domains, so the widely used throwaway providers identified in issue #368 pass Android-side account-creation validation. The current main clone confirms that the reported domains are absent from blockedDomains.

Happy path: each newly added disposable domain in a syntactically valid email returns R.string.auth_email_real_required under the default account-creation behavior, while a normal public email domain remains accepted; Edge cases: mixed-case and surrounding-whitespace variants normalize to a newly blocked domain, and an existing blocked domain remains rejected so the expansion does not regress current coverage.

Fixes #368

@ProdigyV21
ProdigyV21 merged commit 0ddd9f9 into ProdigyV21:main Jul 28, 2026
4 checks passed
@mvanhorn

Copy link
Copy Markdown
Contributor Author

Thank you for merging the blocklist expansion. Appreciate you taking it with the existing normalization and validation order preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: AuthEmailValidator blocklist missing widely-used disposable email domains allowing fake account creation

2 participants