feat(ui): add rounded app icons and Android 13+ themed icon support - #499
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99b98587b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | |||
There was a problem hiding this comment.
On API 26+ devices this new mipmap-anydpi-v26/ic_launcher.xml wins resource selection for R.mipmap.ic_launcher; in LauncherContinueWatchingRepository.ensurePreviewChannel() the code still calls BitmapFactory.decodeResource(context.resources, R.mipmap.ic_launcher) before ChannelLogoUtils.storeChannelLogo, but decodeResource returns null for an adaptive-icon XML resource. When an Android TV preview channel is first created, the channel logo is therefore never stored; please keep a bitmap resource for that code path or render the adaptive drawable to a bitmap.
Useful? React with 👍 / 👎.
2 participants
Summary of Changes
ic_launcher.pngand a circular mask toic_launcher_round.pngacross all density folders (mdpi,hdpi,xhdpi,xxhdpi,xxxhdpi), preserving the original vibrant gradient artwork.ic_launcher_monochrome.xmlusing the normalized vector SVG path for dynamic system Monet theme tinting.ic_launcher.xmlandic_launcher_round.xmladaptive icon manifests linking background (#020204), foreground, and<monochrome>layers.