Skip to content

Fix Chrome/browser errors during ingestion on other machines - #5

Open
CaioHAndradeLima wants to merge 1 commit into
mainfrom
fix/portable-chrome-ingestion
Open

CaioHAndradeLima wants to merge 1 commit into
mainfrom
fix/portable-chrome-ingestion

Conversation

@CaioHAndradeLima

Copy link
Copy Markdown
Collaborator

Problem

  • linkedin-jobs-collect.sh always used hardcoded UVX=/Users/caio/.local/bin/uvx and never .venv → fails on other Macs/clones.
  • linkedin-deep-collect.sh had the same hardcoded uvx fallback.
  • With JOBSEARCH_COLLECT_HEADED=1, preflight reported browser ready whenever channel=chrome was set, even if Google Chrome was not installed → ingestion then failed at launch (“no Chrome”).

Fix

  • Shared scripts/lib/run_collect_python.sh: prefer .venv/bin/python3, then uvx on PATH (or UVX env if set).
  • Headed collect readiness: require installed Chrome or Patchright Chromium (make browser), not channel alone.
  • Clearer error text for headed vs headless; extra Linux/Windows Chrome paths.

For users hitting the error today

make install && make browser
make doctor
# If they don't need visible Chrome:
unset JOBSEARCH_COLLECT_HEADED   # or restart UI without that env
make ui

Test plan

  • pytest tests/retrieval/test_session_extended.py::test_headed_collect_ready_without_chrome_requires_bundled
  • Michele: make pull, make browser, ingestion from UI

Made with Cursor

Remove hardcoded uvx path, run jobs collect via .venv like posts collect,
stop treating channel=chrome as ready without an installed browser, and
add clearer headed/headless missing-browser messages plus Windows Chrome paths.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant