Skip to content

Bug #16747: Logbook : reports download issue - #3922

Merged
hazco75 merged 1 commit into
developfrom
bug_16747_logbook
Aug 18, 2026
Merged

hazco75 merged 1 commit into
developfrom
bug_16747_logbook

Conversation

@hazco75

@hazco75 hazco75 commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

Description

Problèmes de téléchargement des rapports pour l'import de griffons et l'import de scénarios de préservation

Summary by CodeRabbit

  • New Features
    • Added support for downloading reports associated with STP Griffin imports.
    • Added support for downloading reports associated with STP preservation scenario imports.
    • These event types are now recognized in master data downloads.

@hazco75 hazco75 added this to the IT 174 milestone Aug 17, 2026
@hazco75 hazco75 added bug Something isn't working small pr embarquant peu de changements et à review rapide, ne nécessitant qu'un reviewer labels Aug 17, 2026
@coderabbitai

coderabbitai Bot commented Aug 17, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c5b2ae22-86bd-462e-b73e-05064d95e296

📥 Commits

Reviewing files that changed from the base of the PR and between d5c0c96 and a430aa1.

📒 Files selected for processing (1)
  • ui/ui-frontend/projects/referential/src/app/logbook-operation/logbook-download.service.ts

Included review availability: Your plan includes up to 3 reviews per rolling hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The logbook download service now permits STP_IMPORT_PRESERVATION_SCENARIO and maps STP_IMPORT_GRIFFIN and STP_IMPORT_PRESERVATION_SCENARIO masterdata events to report downloads.

Changes

Logbook report download support

Layer / File(s) Summary
Import event type download mapping
ui/ui-frontend/projects/referential/src/app/logbook-operation/logbook-download.service.ts
The service allows STP_IMPORT_PRESERVATION_SCENARIO and returns the report download type for STP_IMPORT_GRIFFIN and STP_IMPORT_PRESERVATION_SCENARIO masterdata events.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to a430a

This localized change addresses report downloads in the logbook area, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the affected report downloads but omits the required change type, documentation, tests, migration, checklist, and contributor sections. Complete the template with the change type, documentation impact, tests performed, migration status, checklist, and contributor.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the logbook report download bug and matches the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bug_16747_logbook

Comment @coderabbitai help to get the list of available commands.

@vitam-prg

Copy link
Copy Markdown
Collaborator

Logo
Checkmarx One – Scan Summary & Details – e2e0b131-1084-44dd-b3ed-ae398d767fca


New Issues (13) Checkmarx found the following issues in this Pull Request
# Severity Issue Source File / Package Checkmarx Insight
1 HIGH CVE-2026-54428 Maven-org.apache.httpcomponents.core5:httpcore5-h2-5.2.4
detailsRecommended version: 5.4.3
Description: Allocation of resources without limits or throttling in the HTTP/2 HPACK decoder in Apache HttpComponents Core through 5.4.2 and 5.5.x through 5.5-...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
2 HIGH CVE-2026-54428 Maven-org.apache.httpcomponents.core5:httpcore5-h2-5.3.6
detailsRecommended version: 5.4.3
Description: Allocation of resources without limits or throttling in the HTTP/2 HPACK decoder in Apache HttpComponents Core through 5.4.2 and 5.5.x through 5.5-...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
3 MEDIUM CVE-2026-19880 Maven-ch.qos.logback:logback-classic-1.4.14
detailsRecommended version: 1.5.16.redhat-00001
Description: Path-traversal vulnerability in QOS.CH Sarl Logback-classic on Java (logback-classic module) allows path-traversal vulnerability. More specifically...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
4 MEDIUM CVE-2026-19880 Maven-ch.qos.logback:logback-classic-1.5.32
detailsRecommended version: 1.6.3
Description: Path-traversal vulnerability in QOS.CH Sarl Logback-classic on Java (logback-classic module) allows path-traversal vulnerability. More specifically...
Attack Vector: NETWORK
Attack Complexity: LOW
Vulnerable Package
5 MEDIUM Parameter_Tampering api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/CasController.java: 239
detailsMethod getUser at line 239 of /api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/CasController.java gets user input from element embe...
Attack Vector
6 MEDIUM Parameter_Tampering api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/TenantController.java: 130
detailsMethod create at line 130 of /api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/TenantController.java gets user input from element dt...
Attack Vector
7 MEDIUM Parameter_Tampering api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/CasController.java: 301
detailsMethod logout at line 301 of /api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/CasController.java gets user input from element authT...
Attack Vector
8 MEDIUM Parameter_Tampering api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/CasController.java: 197
detailsMethod changePassword at line 197 of /api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/CasController.java gets user input from eleme...
Attack Vector
9 MEDIUM Parameter_Tampering api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/TenantController.java: 130
detailsMethod create at line 130 of /api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/TenantController.java gets user input from element dt...
Attack Vector
10 MEDIUM Parameter_Tampering api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/CasController.java: 301
detailsMethod logout at line 301 of /api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/CasController.java gets user input from element authT...
Attack Vector
11 MEDIUM Parameter_Tampering api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/TenantController.java: 130
detailsMethod create at line 130 of /api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/TenantController.java gets user input from element dt...
Attack Vector
12 MEDIUM Parameter_Tampering api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/CasController.java: 221
detailsMethod getUsersByEmail at line 221 of /api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/CasController.java gets user input from elem...
Attack Vector
13 MEDIUM Parameter_Tampering api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/TenantController.java: 130
detailsMethod create at line 130 of /api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/TenantController.java gets user input from element dt...
Attack Vector

Fixed Issues (395) Great job! The following issues were fixed in this Pull Request
Severity Issue Source File / Package
MEDIUM Privacy_Violation api/api-iam/iam-security/src/main/java/fr/gouv/vitamui/iam/security/service/SecurityService.java: 85
MEDIUM Privacy_Violation api/api-iam/iam-security/src/main/java/fr/gouv/vitamui/iam/security/service/SecurityService.java: 85
MEDIUM Privacy_Violation api/api-iam/iam-security/src/main/java/fr/gouv/vitamui/iam/security/service/SecurityService.java: 85
MEDIUM Privacy_Violation api/api-iam/iam-security/src/main/java/fr/gouv/vitamui/iam/security/service/SecurityService.java: 175
MEDIUM Privacy_Violation api/api-iam/iam-security/src/main/java/fr/gouv/vitamui/iam/security/service/SecurityService.java: 175
MEDIUM Privacy_Violation api/api-iam/iam-security/src/main/java/fr/gouv/vitamui/iam/security/service/SecurityService.java: 117
MEDIUM Privacy_Violation api/api-iam/iam-security/src/main/java/fr/gouv/vitamui/iam/security/service/SecurityService.java: 85
MEDIUM Privacy_Violation api/api-iam/iam-security/src/main/java/fr/gouv/vitamui/iam/security/service/SecurityService.java: 85
MEDIUM Privacy_Violation api/api-iam/iam-security/src/main/java/fr/gouv/vitamui/iam/security/service/SecurityService.java: 85
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/CasController.java: 266
LOW Log_Forging api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 216
LOW Log_Forging api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 217
LOW Log_Forging api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 216
LOW Log_Forging api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectController.java: 216
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/AccessContractController.java: 271
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/IngestContractController.java: 231
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/TenantController.java: 130
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 459
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 467
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 467
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 459
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 467
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 459
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 467
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 467
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 459
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 459
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 467
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 459
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 467
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 459
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 459
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 467
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/SchemaUnitController.java: 70
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/SchemaUnitController.java: 58
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 268
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 268
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 268
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 268
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 268
LOW Log_Forging api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/TransactionArchiveUnitController.java: 163
LOW Log_Forging api/api-referential/referential/src/main/java/fr/gouv/vitamui/referential/server/rest/IngestContractController.java: 265
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/UserController.java: 148
LOW Log_Forging api/api-iam/iam/src/main/java/fr/gouv/vitamui/iam/server/rest/UserController.java: 148
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 217
LOW Log_Forging api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/TransactionController.java: 268
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 217
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 179
LOW Log_Forging api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/TransactionController.java: 268
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 217
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 180
LOW Log_Forging api/api-collect/collect/src/main/java/fr/gouv/vitamui/collect/server/rest/ProjectObjectGroupController.java: 151
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 268
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 287
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 179
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 287
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 248
LOW Log_Forging api/api-archive-search/archive-search/src/main/java/fr/gouv/vitamui/archives/search/server/rest/ArchivesSearchController.java: 287

More results are available on the CxOne platform


Use @Checkmarx to interact with Checkmarx PR Assistant.
Examples:
@Checkmarx how are you able to help me?
@Checkmarx rescan this PR

@hazco75
hazco75 merged commit fff7355 into develop Aug 18, 2026
21 checks passed
@hazco75
hazco75 deleted the bug_16747_logbook branch August 18, 2026 07:37
@hazco75 hazco75 added CP V9.1 Tag a PR with this label to automatically create a CP PR on the corresponding maintenance branch CP V9.0 Tag a PR with this label to automatically create a CP PR on the corresponding maintenance branch CP V8.1 Tag a PR with this label to automatically create a CP PR on the corresponding maintenance branch labels Sep 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Successfully created backport PR for master_8.1.x:

@github-actions

Copy link
Copy Markdown
Contributor

Successfully created backport PR for master_9.1.x:

@github-actions

Copy link
Copy Markdown
Contributor

Successfully created backport PR for master_9.0.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CP V8.1 Tag a PR with this label to automatically create a CP PR on the corresponding maintenance branch CP V9.0 Tag a PR with this label to automatically create a CP PR on the corresponding maintenance branch CP V9.1 Tag a PR with this label to automatically create a CP PR on the corresponding maintenance branch small pr embarquant peu de changements et à review rapide, ne nécessitant qu'un reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants