Skip to content

Bug #16836: [Search] The information tooltip remains displayed after selecting a preservation scenario. - #3991

Merged
Salimdev merged 1 commit into
developfrom
bug_16836
Sep 14, 2026
Merged

Salimdev merged 1 commit into
developfrom
bug_16836

Conversation

@Salimdev

@Salimdev Salimdev commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Le tooltip reste affiché après le clic sur le scénario et gêne l’utilisation de l’interface.

Summary by CodeRabbit

  • Bug Fixes
    • Tooltips now close automatically when their associated element is removed from the page.
    • Clicking the element closes its open tooltip.

@Salimdev Salimdev added this to the IT 175 milestone Sep 9, 2026
@Salimdev Salimdev self-assigned this Sep 9, 2026
@Salimdev Salimdev added bug Something isn't working small pr embarquant peu de changements et à review rapide, ne nécessitant qu'un reviewer labels Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 1c8978ad-9072-454d-a85f-c25abf0ace83

📥 Commits

Reviewing files that changed from the base of the PR and between d9e72af and a33eb67.

📒 Files selected for processing (1)
  • ui/ui-frontend/projects/vitamui-library/src/app/modules/directives/ellipsis/ellipsis.directive.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The ellipsis directive now closes its tooltip when the host is clicked or removed from the document. It tracks and clears a connection-check interval during tooltip cleanup.

Changes

Ellipsis tooltip cleanup

Layer / File(s) Summary
Tooltip cleanup behavior
ui/ui-frontend/projects/vitamui-library/src/app/modules/directives/ellipsis/ellipsis.directive.ts
The directive closes the tooltip on host clicks. It checks host connectivity every 100 ms and clears the interval when the tooltip closes.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to a33eb

The shared ellipsis tooltip now closes when its host is clicked or removed, preventing stale tooltips from obstructing the interface. No concrete merge-blocking risk remains.

Suggested reviewers: marob

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description clearly states the bug, but it omits the required sections for change type, documentation, tests, migration, checklist, and contributor. Complete the repository template. Add the change type, documentation impact, test method and results, migration impact, checklist selections, and contributor information.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies bug #16836, the Search context, and the tooltip behavior that the change fixes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bug_16836

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vitam-prg

Copy link
Copy Markdown
Collaborator

Logo
Checkmarx One – Scan Summary & Details411eb81b-12a2-4929-aa67-a15addb6756a


Fixed Issues (1) Great job! The following issues were fixed in this Pull Request
Severity Issue Source File / Package
LOW Log_Forging cas/cas-server/src/main/java/fr/gouv/vitamui/cas/authentication/LoginPwdAuthenticationHandler.java: 194

Use @Checkmarx to interact with Checkmarx PR Assistant.
Examples:
@Checkmarx how are you able to help me?
@Checkmarx rescan this PR

@Salimdev
Salimdev merged commit 6eabb76 into develop Sep 14, 2026
21 checks passed
@Salimdev
Salimdev deleted the bug_16836 branch September 14, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working small pr embarquant peu de changements et à review rapide, ne nécessitant qu'un reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants