Skip to content
This repository was archived by the owner on Mar 25, 2023. It is now read-only.
This repository was archived by the owner on Mar 25, 2023. It is now read-only.

Filter by language #155

Open
Open

Description

@knjk04

Is your feature request related to a problem? If so, please describe.
A user may only want to see their books in their chosen language (e.g. Spanish). Currently, we'd show all books that satisfy the query, regardless of the language.

Describe the solution you'd like
For every GraphQL query, we should have an optional language argument.

Possible approaches:

  • filter the result set
  • define a custom query

Additional context

  • Be sure to read the contributing guidelines first!
  • Discuss your implementation approach with us before we assign you to it
  • Provide us with an estimate on how long you think it will take you to complete
  • Branch from main and set main as the destination branch in your pull request

If you need help with anything, we'll be happy to help you over a GitHub Q&A discussion or our Slack workspace

Activity

  1. gstamatiadis commented on Apr 8, 2022

    @gstamatiadis

    Hello. Could I do this task? I have read the contributing guidelines. I think it will take about one week. My approach would be to write the appropriate query and the corresponding data fetcher.

  2. acyuta1 commented on May 30, 2022

    @acyuta1

    Hey Karan @knjk04,

    I can take this up.
    Should be a straightforward one.

    Approach:

    1. Request would contain an optional 'lang' param.
    2. I feel, filtering the result set is a better option since a where clause in a query seems unnecessary.

    Please let me know if this looks okay! Looking forward to your reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions