Add CreateContactAndContribution-Matcher - #558
Open
CS-DaS wants to merge 12 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to solve #123
It introduces the following PHPStan finding, which could be solved by changing code outside of the scope of this issue (let me know if you want me to fix that as part of this PR):
The PR lacks translation. I will be happy to add translation after clarifying my question in #553
The PR lacks refactoring to avoid code duplication with the CreateContribution matcher. I will soon add this refactoring.
The matcher lacks support for households. It currently only creates Individuals and Organizations. We would prefer to keep it like this due to limited funding. Please let me know if that would prevent you from merging this PR.
If you feel to do so, I would appreciate to already get your feedback on the current state. Thanks for your contributions!