Skip to content

Add CreateContactAndContribution-Matcher - #558

Open
CS-DaS wants to merge 12 commits into
Project60:masterfrom
CS-DaS:issue/123
Open

Add CreateContactAndContribution-Matcher#558
CS-DaS wants to merge 12 commits into
Project60:masterfrom
CS-DaS:issue/123

Conversation

@CS-DaS

@CS-DaS CS-DaS commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

This PR aims to solve #123

It introduces the following PHPStan finding, which could be solved by changing code outside of the scope of this issue (let me know if you want me to fix that as part of this PR):

 ------ --------------------------------------------------------------------------------------------------------- 
  Line   CRM/Banking/PluginImpl/Matcher/CreateContactAndContribution.php                                          
 ------ --------------------------------------------------------------------------------------------------------- 
  156    Parameter #1 $status_id of method CRM_Banking_BAO_BankTransaction::setStatus() expects type, int given.  
         🪪  argument.type                                                                                        
 ------ ---------------------------------------------------------------------------------------------------------

The PR lacks translation. I will be happy to add translation after clarifying my question in #553

The PR lacks refactoring to avoid code duplication with the CreateContribution matcher. I will soon add this refactoring.

The matcher lacks support for households. It currently only creates Individuals and Organizations. We would prefer to keep it like this due to limited funding. Please let me know if that would prevent you from merging this PR.

If you feel to do so, I would appreciate to already get your feedback on the current state. Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant