fix substr cutting special character

[peetCreative]

substr cuts special character in half. So one should replace this function with mb_substring.

Example: A event has the name and the event title contains ß so that it becomes the 64 th character of the contribution source. Then it gets cut in

org.project60.sepapp/CRM/Core/Payment/SDDNGPostProcessor.php

Line 111 in a676114

'source' => substr($contribution['contribution_source'], 0, 64),

and the mechanism breaks. This PR replaces all occurences of substr.

[mattsches]

Thanks for your PR! The change in

org.project60.sepapp/CRM/Core/Payment/SDDNGPostProcessor.php

Line 111 in a676114

'source' => substr($contribution['contribution_source'], 0, 64),

makes sense IMHO, but replacing the occurrences of substr() in the two other files doesn't.

Could you please edit your PR accordingly?

[vurt2]

Good catch! But @mattsches observation is correct: @peetCreative Can you please change the PR only affection the file SDDNGPostProcessor.php.

[peetCreative]

I updated the commit.

[vurt2]

@peetCreative Thank you.

[mhodzn]

I'm taking over for @peetCreative at the moment. Can we expect the pull request to be merged to master soon? That would be very helpful for our project!

[Detsieber]

I am sorry - @vurt2 (Martin Correll) who is in charge of that, will be on vacation until Aug 28.
Will it be sufficient to wait until then?

[mhodzn]

Yes, that is fine. We have implemented the PR fix in our project for now, I just wanted to follow up. Thanks for letting me know!