remove hiding payment instrument id on admin page - #55
Open
peetCreative wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The admin page of a sepa Payment Processor is hiding the payment_instrument_id for some reasons, from years ago. When creating a new Payment Processor, the payment_instrument_id is falsly set to the default (for us PayPal, which we also use).
As the payment Processor rewrites the contributions it does not come up in civicrm, BUT in the confirmation emails sent. There the payment_instrument_id:label is falsly PayPal. Because the payment_instrument_id is taken from the paymentProcessor entry in cicivcrm_payment_processor.payment_instrument_id.
This PR makes it possible to fix the Problem in the Admin Frontend.