fix: resolve WalletProvider requireWallet stale closure (Closes #490) - #575
Open
waterWang wants to merge 1 commit into
Open
fix: resolve WalletProvider requireWallet stale closure (Closes #490)#575waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…col-Guild#490) requireWallet captured `address` from the render where it was defined. After connect() resolves, the state update from onWalletSelected hasn't been applied yet, so the post-modal check always read the stale null and threw "Wallet connection required" even though the user just connected. - Keep addressRef in sync with the address state via useEffect - Write addressRef.current synchronously in onWalletSelected so requireWallet sees the fresh value without waiting for a re-render - Wrap connect/requireWallet in useCallback to avoid re-renders
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the stale closure in
requireWalletthat caused the first transaction after wallet connect to always fail with "Wallet connection required".Root Cause
requireWalletcapturedaddressfrom the render where it was defined. Afterconnect()resolved, the state update fromonWalletSelected(which callssetAddress) hadn't been applied yet, so the post-modal checkif (!address)always read the stalenull.Changes
useRef): Kept in sync withaddressstate viauseEffect, so async callbacks always read the latest valueaddressRef.currentsynchronously — even before the state update renders,requireWalletsees the fresh addressuseCallbackto prevent unnecessary re-rendersVerification
npx tsc --noEmit— passesnpm run lint— 0 errors, 0 warningsnpx prettier --check— passesAcceptance Criteria