fix: handle 401 responses globally with axios interceptor (Closes #473) - #593
Open
waterWang wants to merge 1 commit into
Open
fix: handle 401 responses globally with axios interceptor (Closes #473)#593waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
Add a global axios response interceptor so expired sessions never surface as silent spinners or empty tables. On 401 (non-auth endpoints) the interceptor: clears the payd_auth_token from localStorage, shows a sonner toast 'Session expired, please log in again', and redirects to /login. Registers on both the shared api instance and bare axios calls, with guards for /auth endpoints and redirect loops. Closes Protocol-Guild#473
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a global axios response interceptor that handles 401 Unauthorized responses across the entire application. Previously, expired tokens caused silent failures (spinners, empty tables) with no feedback to the user.
Changes
frontend/src/utils/api.ts— AddedhandleUnauthorizedfunction that:apiinstance and bareaxios.*callslocalStorage/loginso the user can re-authenticate/auth/endpoints to avoid interfering with legitimate login flowsfrontend/src/main.tsx— Added side-effect import of./utils/apito ensure the global interceptor is registered at app startupWhy this approach
The project's service files use bare
axios.get/postcalls (not a shared instance). Registering the interceptor on bothaxios.interceptors.response(global) andapi.interceptors.response(shared instance) ensures every API call is covered — no silent failures slip through.Testing
tsc --noEmitpasses)/auth/endpoints is skipped (login flow unaffected)/login/loginwhen 401 fires → no redirect loopCloses #473