feat: add proper 404 Not Found page (Closes #468) - #596
Open
waterWang wants to merge 1 commit into
Open
Conversation
- Replace silent redirect-to-home with a dedicated 404 page - Add NotFound.tsx page component with links to Home, Payroll, Employees, and Help Center - Add i18n translations for both English and Spanish - Use existing card glass noise styling for visual consistency Closes Protocol-Guild#468
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the silent catch-all redirect (
<Navigate to="/" replace />) with a dedicated 404 Not Found page that helps users understand what went wrong and navigate to useful destinations.Changes
frontend/src/pages/NotFound.tsx: A dedicated 404 page styled with the existingcard glass noisedesign system, showing a 404 badge, message, and navigation links.frontend/src/App.tsx: Changed the catch-all routepath="*"from a silent redirect to render<NotFound />.notFoundtranslation keys to bothenandeslocale files (Spanish: "Página no encontrada").Navigation Links
//payroll/employee/helpWhy
Users previously got silently redirected to the home page on invalid URLs, which is confusing and makes routing bugs hard to debug. A proper 404 page improves UX and gives users clear recovery paths.
Verification
tsc --noEmitpasses with no errors.Closes #468