feat: expose lossless MySQL user variables - #55
Merged
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
ProxySQL currently falls back to hostgroup locking for client statements such as:
The downstream consumer needs typed assignments and the exact literal spelling before it can safely track and replay these values. Reconstructing that information from normalized SQL would lose literal semantics, so ParserSQL is the source of truth.
Details
NULLliteral nodes+/-signs for numeric literalsValidation
make test: 1,333 tests run; 1,296 passed; 37 backend-dependent tests skippedmake build-corpus-test: passedDownstream
Companion ProxySQL PR: sysown/proxysql#6043
That PR vendors the archive produced from commit
db9d464c334eaba236bea16a6e9eb6efa7c3a863and uses these typed results for bounded user-variable tracking and backend replay.