feat: prune OR/range, pool PostgreSQL, 2PC stress, honest docs - #60
Merged
Conversation
Prune shard_key OR-of-equalities and RANGE inequalities/BETWEEN. Placeholders still scatter. ThreadSafeMultiRemoteExecutor pools PostgreSQL as well as MySQL. engine_stress_test uses DistributedTransactionManager. README matches current Session/ShardMap and tool 2PC behavior.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ribute Flatten UNION ALL remotes so N shards open together. Route composite HASH keys, fail unknown tables, and move rows on shard-key UPDATE. LIST misses fail closed and BETWEEN/IN prune; composite colocated joins push when every key part is equated. Cache the logical plan and re-distribute on each hit.
2 tasks
- Composite RANGE now routes and prunes on the first key component (LIST still rejects composites; HASH uses all parts). - Semi-join prune: when one side of a join is sharded and the other is not, the engine materializes the small side and pushes an IN-list onto the sharded probe side. - New demo scripts for PostgreSQL shards (16432/16433) exercising RANGE + LIST + cross-shard 2PC with DistributedTransactionManager in POSTGRESQL mode. - sqlengine now auto-selects PostgreSQL 2PC dialect when all backends are pgsql://. - Added planner and live-backend tests; full suite now 1344 passed. Stacked on PR #61.
…range feat: composite RANGE, semi-join prune, PG LIST/RANGE + 2PC demo
feat: parallel scatter, composite keys, LIST prune, plan-cache redistribute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #56 (which now contains #57–#59).
id = 1 OR id = 2unions shards; RANGEid <= N/BETWEENprunes.id = ?still scatters.ThreadSafeMultiRemoteExecutordispatches PostgreSQL throughPgConnectionPool+ pinnedPooledPgSession.engine_stress_testusesDistributedTransactionManager.add_table(notadd_sharded_table); Session example uses 2PC; pooling/DML claims match the code.Validation
./run_tests --gtest_brief=1: 1325 passed, 39 skipped./run_tests --gtest_filter='DistributedPlannerTest.ShardRouting_*:ShardMapRangeTest.*'