Skip to content

fix(web): drop trailing slash from the navbar Dashboard link - #119

Merged
renecannao merged 2 commits into
ProxySQL:masterfrom
qveensi:fix/webui-dashboard-trailing-slash
Aug 11, 2026
Merged

fix(web): drop trailing slash from the navbar Dashboard link#119
renecannao merged 2 commits into
ProxySQL:masterfrom
qveensi:fix/webui-dashboard-trailing-slash

Conversation

@qveensi

@qveensi qveensi commented Aug 3, 2026

Copy link
Copy Markdown

The router registers /web/clusters without a trailing slash and does not redirect, so the Clusters ▸ Dashboard navbar entry returns HTTP 404. Every other link in the same dropdown already omits the slash.

Part of #118 (residual BS3→BS5 migration leftovers); this is the trivial one.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the Clusters “Dashboard” navigation link to use the correct URL format without a trailing slash.

The router registers /web/clusters without a trailing slash and does
not redirect, so the Dashboard entry in the Clusters navbar dropdown
returns HTTP 404. Every other link in the dropdown already omits the
slash.
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@renecannao, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 196235c6-efe4-4dc7-bb53-706c1def8a1f

📥 Commits

Reviewing files that changed from the base of the PR and between 3f1eb80 and 6c0c99b.

📒 Files selected for processing (2)
  • go/http/render_test.go
  • resources/templates/layout.tmpl
📝 Walkthrough

Walkthrough

The Clusters Dashboard navigation link now points to /web/clusters without a trailing slash.

Changes

Clusters Dashboard URL

Layer / File(s) Summary
Update Dashboard navigation link
resources/templates/layout.tmpl
The Clusters Dashboard link changes from /web/clusters/ to /web/clusters.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

A rabbit hops through paths so neat,
No trailing slash beneath its feet.
The Dashboard link now lands just right,
Clean and crisp in every byte.
“Hop!” says Bun, and ends the night.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the trailing slash from the web navbar Dashboard link.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@renecannao

Copy link
Copy Markdown

Thank you very much, @qveensi. This was a precise, well-explained fix for an easy-to-miss routing mismatch. The contribution also led us to add coverage that checks navbar links against registered routes and to fix the adjacent Failure Analysis link. All 17 checks are green. We genuinely appreciate you taking the time to find, explain, and fix this.

@renecannao
renecannao merged commit 5f2b4d2 into ProxySQL:master Aug 11, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants