fix(web): drop trailing slash from the navbar Dashboard link - #119
Conversation
The router registers /web/clusters without a trailing slash and does not redirect, so the Dashboard entry in the Clusters navbar dropdown returns HTTP 404. Every other link in the dropdown already omits the slash.
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Warning Review limit reached
Next review available in: 59 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Clusters Dashboard navigation link now points to ChangesClusters Dashboard URL
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you very much, @qveensi. This was a precise, well-explained fix for an easy-to-miss routing mismatch. The contribution also led us to add coverage that checks navbar links against registered routes and to fix the adjacent Failure Analysis link. All 17 checks are green. We genuinely appreciate you taking the time to find, explain, and fix this. |
The router registers
/web/clusterswithout a trailing slash and does not redirect, so the Clusters ▸ Dashboard navbar entry returns HTTP 404. Every other link in the same dropdown already omits the slash.Part of #118 (residual BS3→BS5 migration leftovers); this is the trivial one.
Summary by CodeRabbit