Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ability to set initial target of a solo duty in a quest path. might fix a lot of cases where the only thing preventing a solo duty from running is targeting a boss. Below is summary of LLM-assisted fix for unload error introduced by IAsyncDalamudPlugin change @Kagekazu
Fix ObjectDisposedException on plugin unload
Since moving to
IAsyncDalamudPlugin, unloading Questionable could throwObjectDisposedExceptionfromMovementController.UpdateviaIFramework.Update. MS.DI'sServiceProviderEngineScopemarks itself disposed at thestart of
DisposeAsync, before walking the disposable list. Under the async plugin lifecycle Dalamud's frameworkthread can tick between "scope flagged disposed" and
DalamudInitializerbeing reached in the disposal walk, soMovementController.Update's per-frameIServiceProvider.GetRequiredService<QuestController>()blew up on a deadcontainer. The classic sync
Disposepath masked this because teardown ran inline without yielding the frameworkthread.
Changes:
QuestionablePlugin.DisposeAsync: resolve andDispose()DalamudInitializerbefore disposing the container(wrapped in
try/catch (ObjectDisposedException)for the already-torn-down case), so Dalamud event subscriptions(
Framework.Update,UiBuilder.*, toast hooks) are gone before the scope is flagged disposed.DalamudInitializer.Dispose: added a_disposedguard so the explicit pre-container call plus MS.DI's laterdisposal walk are both safe.
MovementController: replaced theIServiceProviderconstructor parameter withLazy<QuestController>,breaking the
QuestController↔MovementControllerctor cycle without a runtime container lookup on the hot path.Registered explicitly as
AddSingleton(sp => new Lazy<QuestController>(sp.GetRequiredService<QuestController>))(MS.DI doesn't auto-provide
Lazy<T>).Verified with
dotnet build -c Release Questionable/Questionable.csproj(0 warnings, 0 errors) and by reloading theplugin locally — the unload error no longer reproduces.
AI/LLM disclosure: implemented with Claude Opus 4.7 via pi. Diagnosis, fix design, and code were reviewed and
are owned by @alydevs.