chore: delete dead PYAUTO_SMALL_DATASETS/PYAUTO_FAST_PLOTS from build profiles#29
Merged
Merged
Conversation
… profiles Neither knob is ever read in an autofit-only workspace. PYAUTO_SMALL_DATASETS is read only in PyAutoArray/PyAutoGalaxy/PyAutoLens; PYAUTO_FAST_PLOTS only in PyAutoArray and PyAutoGalaxy. PyAutoFit does not import autoarray and no script here imports autoarray/autogalaxy/autolens, so the reading code never loads. The stale comments gave the copy-paste away: an autofit config claiming to 'reduce MGE gaussians' and skip 'critical curve/caustic overlays'. Refs PyAutoLabs/autofit_workspace#111
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PYAUTO_SMALL_DATASETSandPYAUTO_FAST_PLOTSare dead config here — nothing that reads them is ever imported in an autofit-only workspace. This deletes them from thedefaults:block of this repo's build profile(s).PYAUTO_SMALL_DATASETSis read only in PyAutoArray (util/dataset_util.py,structures/grids/uniform_2d.py,mask/mask_2d.py,operators/over_sampling/over_sample_util.py,operators/convolver.py), PyAutoGalaxy and PyAutoLens. Zero occurrences in PyAutoFit or PyAutoNerves — not even a docstring.PYAUTO_FAST_PLOTSis read inautoarray/plot/utils.pyandautogalaxy/util/plot_utils.py. In PyAutoFit it appears only in prose (autofit/non_linear/quick_update.py:71and a test docstring), never in anos.environlookup.tight_layout()is inautofit/non_linear/live_viewer.py:102, inside the interactiveplt.ion()desktop viewer, which never runs headless in CI. WiringPYAUTO_FAST_PLOTSup there would buy nothing, so deletion is the right call rather than implementation.The stale comments gave the copy-paste origin away: an autofit config claiming to "reduce MGE gaussians" and skip "critical curve/caustic overlays", both lensing concepts.
This does not violate the release-profile doctrine ("every var this profile cares about gets an EXPLICIT value, not left absent") — autofit cares about neither, so absence is correct rather than a fall-through hazard.
autofit_workspace_test/config/build/env_vars_release.yamlalready omitted both and is untouched.Follow-up to #321 (the env_vars key-order sweep), which made the profiles diffable and surfaced this.
Scripts Changed
None — configuration only. No file under
scripts/is touched.config/build/env_vars*.yaml— removed the two deaddefaults:entries. Nooverrides:entry referenced either key, so the change is contained todefaults:.Test Plan
resolve_clean()(PyAutoHands/autohands/validate_env_profiles.py): onlyPYAUTO_SMALL_DATASETSandPYAUTO_FAST_PLOTSdisappear. Zero other key added, removed or changed;overrides:andargs_defaultbyte-identical in every profile.validate_env_profiles.pyverdict unchanged frommain.git diff --statcontains nothing butconfig/build/env_vars*.yaml..pyin autofit_workspace / autofit_workspace_test / HowToFit references either var.Refs PyAutoLabs/autofit_workspace#111.
Generated by the PyAutoLabs agent workflow.