refactor: adopt shared env_config resolver in run_smoke#32
Merged
Conversation
…185) Collapse this repo's hand-forked env resolution (local load_env_config / pattern_matches / build_env) onto PyAutoHands autohands/env_config.py — the fork omitted the ambient PYAUTO_* scrub and derive_jax_markers support (env_profile_redesign.md §5, the "one resolver" rule). Verified by resolved-env diff over the smoke list and every script under scripts/ (old fork logic vs shared resolver, empty base): 0 diffs. Part of a 674-entry / 0-diff sweep across all six migrated repos. Only behavioural change: ambient PYAUTO_* vars no longer leak into script runs (nothing in the PR gate injects any). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRQH5HrmMPfpWkmfh3ysJb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Collapses this repo's hand-forked env resolution in
.github/scripts/run_smoke.pyonto the shared resolverPyAutoHands/autohands/env_config.py(PyAutoLabs/PyAutoHands#185, Phase 1a of the test-maintainability plan). The fork predated the env-profile redesign's "one resolver" rule and omitted both the ambientPYAUTO_*scrub andderive_jax_markerssupport — the silent-fork shape behind the five-night seed incident.Scripts Changed
.github/scripts/run_smoke.py— localload_env_config/pattern_matches/build_envdeleted; now importsenv_config.build_env_for_script/load_env_config(CI PYTHONPATH wiring already exists in the reusable smoke workflow; sibling-checkout fallback for local runs). The migrated file is byte-identical to the Family-A template (autofit_workspace_test).Verification
Resolved-env diff over the smoke list ∪ every script under
scripts/(old fork logic vs shared resolver, empty base): 0 diffs (part of the 674-entry / 0-diff sweep across all six migrated repos). Only behavioural change: ambientPYAUTO_*vars no longer leak into script runs — nothing in the PR gate injects any, so CI is unaffected.Ship note
Shipped under human-authorized Heart-RED exception (RED reason:
release validation FAILED (stage integrate)— pre-existing and unrelated to this change).Linked issue: PyAutoLabs/PyAutoHands#185
🤖 Generated with Claude Code
https://claude.ai/code/session_01MRQH5HrmMPfpWkmfh3ysJb