docs(no_run): correct the SLOW-skip timeout cap (300s/1800s, not 60s)#43
Merged
Conversation
The header claimed a '60s per-script timeout cap'. The enforced value is PyAutoHands autobuild/build_util.py TIMEOUT_SECS: 300s by default, raised to 1800s for mode=release runs. A 5x understatement biases every 'is this too slow to un-skip?' judgement toward parking scripts that would pass. Matches PyAutoHands#172, which fixes the same stale figure in the mega-run banner and report text. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to PyAutoLabs/PyAutoHands#172.
The
config/build/no_run.yamlheader documented a "60s per-script timeout cap". No such cap is enforced. The real values:PyAutoHands/autobuild/build_util.py:12,TIMEOUT_SECS = int(os.environ.get("BUILD_SCRIPT_TIMEOUT", "300")).mode=release:PyAutoHeart/.github/workflows/workspace-validation.yml:308.A 5× understatement of the cap biases every "is this script too slow to un-skip?" judgement in the same direction — toward parking scripts that would in fact pass. It did exactly that while triaging autolens_workspace_test#193: a clean run of
database/scrape/generalmeasured 214s, which reads as an obvious SLOW-skip against 60s but has ~86s of headroom against the real 300s cap.Comment-only; one line of the header replaced by two. No behaviour change.
Scripts Changed
None (
config/build/no_run.yamlheader comment only).