chore(no_run): drop dead group/slam marker and inert tutorial_10 SLOW entry#44
Merged
Merged
Conversation
… entry `group/slam` is copy-paste cruft from autolens_workspace and matches zero files here (HowToLens holds only scripts/chapter_*/ and scripts/simulator/). `howtolens/chapter_4_pixelizations/tutorial_10_brightness_adaption` is different: the file really exists, but the stale pre-split `howtolens/` prefix means the substring has never matched since the repo split, so the entry has been inert and the tutorial has been running in CI regardless. Its stated reason — "exceeds 60s test timeout" — rests on a cap that does not exist: run_all.py sets DEFAULT_TIMEOUT_SECS = 300. Measured 233.7s, exit 0, so it fits the real cap. Repairing the prefix would therefore newly park a passing script; deleting the entry is behaviour-preserving. If CI proves slower than 300s, the fix is a correctly-spelled SLOW entry, not this one. Live entries unchanged (tutorial_searches, tutorial_5_borders still resolve). Refs PyAutoLabs/HowToGalaxy#34 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes two
no_run.yamlentries. They look alike but fail for different reasons.1.
group/slam— dead copy-paste cruftCopy-pasted from autolens_workspace when the tutorials were split out. HowToLens holds only
scripts/chapter_*/andscripts/simulator/, so this matches zero files and has never gated anything. It advertises a bug that does not exist here and inflates Heart's stale-parked count.2.
tutorial_10_brightness_adaption— a broken pattern, and its premise is falseThis is not cruft — the file genuinely exists at
scripts/chapter_4_pixelizations/tutorial_10_brightness_adaption.py. But the stale pre-splithowtolens/prefix means the substring never matches, so the entry has been inert since the repo split and the tutorial has been running in CI all along.The obvious fix — repair the prefix — would be wrong:
PyAutoHands/autobuild/run_all.pysetsDEFAULT_TIMEOUT_SECS = 300.Repairing the prefix would therefore newly park a script that passes. Deleting the entry is behaviour-preserving — it changes nothing about what runs today — and removes a line that misstates both the pattern and the cap.
Risk note: 233.7s of a 300s budget is 22% headroom, measured on a laptop. If CI proves slower and this times out, the correct response is a correctly-spelled entry (
chapter_4_pixelizations/tutorial_10_brightness_adaption), not restoring the broken one.Audit context
30 of this repo's 32 entries match zero files. Only the two above are touched; the rest is reported in PyAutoLabs/HowToGalaxy#34 and deliberately left alone, since several are stem patterns that may be prospective guards. Also left for a human:
tutorial_6_model_fit, whose stem has never existed in this repo's history and whose intended target is ambiguous.Verification: YAML re-parses (30 entries); live-entry set byte-identical before and after —
tutorial_searchesandtutorial_5_bordersstill resolve.Scripts Changed
None (config-only). No script changes what it does;
tutorial_10_brightness_adaption.pyalready ran in CI and continues to. Notebooks not regenerated.Refs PyAutoLabs/HowToGalaxy#34
🤖 Generated with Claude Code