refactor: validate env profiles for every smoke-profile workspace#103
Merged
Conversation
…AutoHands#185) The PR-time profile validation gate only fired for workspaces carrying a profile_release.yaml, which exempted exactly the smoke-only repos (HowTo*) — the ones whose run_smoke.py forks just collapsed onto the shared resolver. Now the validator runs for any workspace with a config/build/profile_smoke.yaml; the release-only strict flags (--strict-derivation --strict-markers) still apply only where a profile_release.yaml exists. Requires PyAutoHands' companion change making the release profile optional in validate_env_profiles.py (merge that first). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MRQH5HrmMPfpWkmfh3ysJb
Jammy2211
added
the
pending-release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Part of PyAutoLabs/PyAutoHands#185 (Phase 1a: Family-B env-resolver unification). The PR-time profile validation step in the reusable smoke workflow only fired for workspaces carrying a
profile_release.yaml— exempting exactly the smoke-only HowTo repos whose forkedrun_smoke.pyjust collapsed onto the shared resolver. Config-only errors in those repos would surface in the nightly instead of failing the PR in seconds.Scripts Changed
.github/workflows/smoke-tests.yml— validate step now fires for any workspace withconfig/build/profile_smoke.yaml; the release-only strict flags (--strict-derivation --strict-markers) still apply only where aprofile_release.yamlexists (the*_workspace_testrepos and the three user workspaces, whose behaviour is unchanged).Verification
Merge order: merge PyAutoLabs/PyAutoHands' companion PR first — the new condition calls the validator on smoke-only repos, which requires its release-profile-optional change. (The workflow clones PyAutoHands at the matching branch where one exists,
mainotherwise.)Ship note
Shipped under human-authorized Heart-RED exception (RED reason:
release validation FAILED (stage integrate)— pre-existing and unrelated to this change).Linked issue: PyAutoLabs/PyAutoHands#185
🤖 Generated with Claude Code
https://claude.ai/code/session_01MRQH5HrmMPfpWkmfh3ysJb