refactor: purge the autoconf-era legacy surface#138
Merged
Conversation
`test_path_empty` ran `os.makedirs("bad/path")` relative to the CWD and never
cleaned up, so every test run left a `bad/` directory behind in whatever
directory pytest was invoked from. Move both path-validation tests onto
pytest's `tmp_path` and drop the now-unused `BAD_PATH` constant and
`remove_path()` helper.
Fixes the producer rather than gitignoring the symptom.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The Euclid EDEN packaging path has been dormant for years. Its driver, `scripts/edenise.py`, imports `autofit.tools.edenise`, which no longer exists in PyAutoFit — the script raises ImportError on run. It also reads an `eden.ini` that was removed org-wide on 2026-07-13, so the `eden.yaml` left here was never even the file it consumed. Nothing else in the repo, the libraries, or any workspace references either file. Wired into no CI and no build. The PyAutoNerves leg of the eden-tooling removal; `PyAutoFit/eden.yaml` is a follow-up (PyAutoFit is currently claimed by another task). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
`scripts/` held four drivers used to set up the original configs years ago. They are wired into no CI, referenced from no workspace, and two no longer even import: - `convert_config.py` — the .ini -> YAML migration, long since run - `convert_prior_configs.py` — imports `oyaml`, not a declared dependency - `generate_priors.py` — CLI over `json_prior/generate.py` `json_prior/generate.py` had no consumer beyond that CLI and its own test, and is not exported from `autonerves/__init__.py`, so it goes with them. The live half of the package, `json_prior/config.py`, is untouched — it is imported by `conf.py` and re-exports `default_prior`, `make_config_for_class`, `path_for_class` and `JSONPriorConfig`, all verified still resolving. `priors/subconfig.json` was a stray output artifact of `generate_priors.py`. Both `scripts/` and `priors/` disappear; neither is referenced from `pyproject.toml`, `setup.py` or `MANIFEST.in`. 149 passed (the 2 removed are `test_generate.py`'s own). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #137 (steps 1–3).
Three atomic commits, each independently revertable.
test:stoptest_configlitteringbad/in the repo roottest_path_emptyranos.makedirs("bad/path")relative to the CWD and never cleaned up, so every test run left abad/directory behind. Both path-validation tests move ontotmp_path. Fixes the producer rather than gitignoring the symptom.refactor:remove the dead EDEN packaging toolingscripts/edenise.pyimportsautofit.tools.edenise, which no longer exists in PyAutoFit — it raisesImportErroron run. It also reads aneden.iniremoved org-wide on 2026-07-13, so theeden.yamlsitting here was never even the file it consumed. Both deleted.PyAutoFit/eden.yamlis a follow-up — PyAutoFit is currently claimed by thetestmode-env-driftworktree.refactor:remove the one-shot config-bootstrap toolingscripts/held four drivers used to set up the original configs years ago, wired into no CI and referenced from no workspace. Two no longer even import:convert_config.py.ini→ YAML migration, long since runconvert_prior_configs.pyoyaml— not a declared dependencygenerate_priors.pyjson_prior/generate.pyedenise.pyjson_prior/generate.pyhad no consumer beyond that CLI and its own test, and is not exported fromautonerves/__init__.py, so it goes with them.priors/subconfig.jsonwas a stray output artifact ofgenerate_priors.py. Bothscripts/andpriors/disappear; neither is referenced frompyproject.toml,setup.pyorMANIFEST.in.json_prior/config.pyis deliberately untouched — the live half, imported byconf.pyand re-exportingdefault_prior,make_config_for_class,path_for_class,JSONPriorConfig. All four verified still resolving after the deletion.Not in this PR
The
autoconf/,test_autoconf/,autoconf.egg-info/andbuild/directories that prompted this task turned out to be untracked working-copy leftovers —git grep -ril autoconfover tracked files returns nothing, so there is no diff to make. They were cleared locally. Worth recording that they were not inert:build/lib/autoconf/held a full stale copy of the pre-rename source, andautoconf/still resolved as a namespace package, shadowing imports.Testing
151 passedbefore,149 passedafter — the two removed aretest_generate.py's own. Confirmed nobad/directory is created by a run.