Repository navigation
Drop workbench's hero_canvas, which nothing serves - #64
Merged
Merged
Conversation
The validator now refuses a hero on a page=none entry, so the next one is caught when the database is edited.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60.
workbench's entry is
page: none, so the generator writes no landing page for it, and itshero_canvas(the polyhedron app) ran nowhere. https://pydevices.github.io/workbench/ is the IDE's own site.This removes the block and makes
validate_db()refuse ahero_canvason apage: noneentry.tests/test_validate_db.pycovers both: it fails on main (workbench is listed, and the validator lets a planted page=none hero through) and passes here.