Repository navigation
display_driver moves to pydevices; the bindings keep fs_driver - #25
Merged
Merged
Conversation
display_driver is PyDevices plumbing: it imports appdev, events, keys and
multimer and builds its App from board_config. It now lives in
PyDevices/pydevices lib/ and ships with pydevices, so a change to it no
longer needs a bindings release, and the bindings stay usable by anyone
with plumbing of their own. fs_driver imports only lvgl and stays.
packages/display_driver.json goes with it: mip.install("pydevices") carries
display_driver now. The pacing and direct-frame tests move to pydevices'
tests/test_lvgl_display_driver.py; the nesting test keeps the half that is
this repo's, that the generated MicroPython and CircuitPython C export
_nesting, as tests/test_nesting_export.py.
This was referenced Oct 7, 2026
…hes display_driver The pinned lvgl-python (7883313) syncs python/display_driver.py, which this branch removes. f0e8be5 is lvgl-python#26's head; repin to its merge commit once it lands.
This was referenced Oct 7, 2026
Merged
bdbarnett
added a commit
that referenced
this pull request
Oct 8, 2026
display_driver lives in PyDevices/pydevices' lib/ since #25, so the page that explains it moves there too (PyDevices/pydevices#132). Both README links point at its new home.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
display_driver.pynow lives in PyDevices/pydeviceslib/(PyDevices/pydevices#129). It imports appdev, events, keys and multimer and builds its App fromboard_config, so it belongs with them; the bindings stay usable by anyone with plumbing of their own, and a change to display_driver no longer needs a bindings release.fs_driver.pyimports only lvgl and stays.This removes
python/display_driver.pyandpackages/display_driver.json(mip.install("pydevices")carries it now), and repoints the docs and the generator comments about_nestingat pydevices' copy.The tests split along the same line. The pacing and direct-frame tests moved to pydevices'
tests/test_lvgl_display_driver.py.tests/test_nesting_export.pykeeps this repo's half of the_nestingcontract: the generated MicroPython and CircuitPython C still export it.This replaces #24, whose frame-hook change is in the file pydevices now carries.
Merge order. Merge this after PyDevices/lvgl-micropython, PyDevices/lvgl-circuitpython and PyDevices/lvgl-python's removal PRs. Their old sync scripts fetch
python/display_driver.pyand would fail on a bindings ref without it. Its CI already needed this: the CPython integration job runs the pinned lvgl-python's sync script, which fetchedpython/display_driver.pyand failed.linux-integration.ymlnow pins lvgl-python at #26's head (f0e8be5). Repin it to #26's merge commit when that lands. The next bindings release then makes thepydevices-lvglwheel without the file. Cut that one after a pydevices release that has it.pytest tests/test_nesting_export.py tests/test_generation_tools.py: 40 pass.test_pyi_only_generation_uses_existing_inputsneeds the lvgl submodule, which this worktree doesn't have; it passes on the main checkout.