Repository navigation
Conversation
…counts it The same change as lvgl-bindings' python/display_driver.py (its PR displaydev-fps), carried here so the frozen copy has it before the next sync; the sync after that PR merges brings an identical file and moves LVGL_BINDINGS_COMMIT.
This was referenced Oct 7, 2026
Collaborator
Author
|
Closing in favour of the move: this was the byte-identical copy of lvgl-bindings#24, and that file now lives in PyDevices/pydevices lib/ (PyDevices/pydevices#129). This repo's removal PR is #24. |
bdbarnett
added a commit
that referenced
this pull request
Oct 7, 2026
LVGL's PyDevices coordinator moved to PyDevices/pydevices lib/, beside the appdev, events, keys and multimer it imports, and comes with the pydevices mip package or micropython-pydevices' --modules pydevices. This repo now freezes fs_driver only and syncs only that from lvgl-bindings. Replaces #23, whose frame-hook change is in pydevices' copy (PyDevices/pydevices#129). Merge after #129: on its own this leaves a firmware without pydevices with no display_driver, which it could not import anyway (it needs appdev).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same change as PyDevices/lvgl-bindings#24, brought into
lib/display_driver.pyso the frozen copy has it. The file is byte-identical to that branch'spython/display_driver.py. Once the bindings PR merges,scripts/sync_from_lvgl_bindings.shbrings an identical file and movesLVGL_BINDINGS_COMMIT. You can also merge that sync in place of this PR.On a direct-framebuffer panel (the P4's DSI panel, CastDisplay), the last area of each frame now ends in one present:
show()whenflush_rectcouldn't sync the area, otherwise the panel'sframe_done(), displaydev's new frame-rate hook, which is a no-op unlessmeasure_fpsis on.presentscounts both, so on the P4 it now counts frames. Before, it stayed at 0.Desktop MicroPython with this file and the pydevices branch: frames 125 against presents 125 and 251 flushes on a panel whose
flush_rectsyncs, and 124 / 124 / 249 on one that falls back toshow(). The measurements are in the bindings PR.Only
lib/display_driver.pychanges. This PR stays clear ofmicropython.mk, which the native-Windows PR is editing.