Repository navigation
Patch 0018: a fresh ESP-IDF clone builds the S3 again; lock at the KeDei merges - #35
Merged
Merged
Conversation
…xist (a fresh ESP-IDF v5.5.4 clone broke every S3 build with cameraif or displayif); modules.lock: displayif and pydevices at the KeDei merges
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second cloud run of
scripts/exercise_build.sh(2026-10-06) built every target in one go, ESP-IDF fetched bybuild_mp.pyincluded, except the ESP32-S3. It failed at configure:Include directory '.../esp_hw_support/mspi_timing_tuning/port/esp32s3/include' is not a directory.The cause. ESP-IDF v5.5.4's S3 port declares that
includedirectory but tracks no files in it, so a fresh clone never creates it. ESP-IDF itself tolerates that. MicroPython's esp32 port doesn't.usermod.cmakegathers include directories transitively from every library a user C module links, and cameraif and displayif link ESP-IDF driver components that pull inesp_hw_support.idf_component_register()then refuses the missing directory. The ESP-IDF in the workspace had once been at an older tag and still had the empty directory, which hid it. With that removed, so the checkout matches a clean v5.5.4, the failure reproduced here in 28 seconds.The fix. Overlay patch 0018 drops non-existent directories (generator expressions are kept) from
MICROPY_INC_USERMODbeforeidf_component_register(). It's in the series' usual form, with a justification header and its checksum inprovenance.json.apply_patches.py --check: the series applies clean to v1.29.0. With it, the S3 LCD-7--modules allbuild passes against the clean ESP-IDF (9 m 0 s, autosize included). It's an upstream MicroPython bug too, and the draft for upstream is a separate issue.modules.lockmoves displayif to PyDevices/displayif#48 (mipidsinon_burst/continuous_clock) and pydevices to PyDevices/pydevices#123 (the DEV-KIT + KeDei board config), both proven on Brad's bench today.