Refresh regenerates the site page and redeploys it - #4
Merged
Merged
Conversation
The package-list refresh updated packages.json and the README but never .site/index.html, so the rendered page lagged one publication behind and .github's generator-idempotency check failed after every release until the page was regenerated by hand (PyDevices/.github#51, micropython#54). The refresh job now runs .github's generate_sites.py --only mip after update_package_list.py and commits the page with the list. When the page changed, it re-uploads the artifact that just went live with only index.html replaced, and a new job deploys it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After every publication, the rendered page at https://PyDevices.github.io/mip/ now shows the same versions as
packages.json. Before this it lagged one release, and.github's generator-idempotency check failed until someone regenerated the page by hand (PyDevices/.github#51, PyDevices/.github#54; mip has issues disabled).What changes in
refresh-package-list.yml:update_package_list.py, it checks out PyDevices/.github atmainand runsscripts/generate_sites.py --only mip..site/index.htmlthen goes into the same commit as the list.index.htmlreplaced, and a newredeploy-site-pagejob deploys it. index.json and the packages aren't rebuilt, so they stay exactly as the first deploy published them.pages: writeandid-token: writefor the redeploy.Merge PyDevices/.github#55 first. It adds
--only. Until it's on.github's main, the regenerate step fails. The list is still committed in that case, but the job goes red.How I checked it: actionlint 1.7.12 and a YAML parse are clean. I ran the new shell steps by hand on a clone at 855fd90, the refresh commit whose page was stale.
page-changed=truecame out, and the regenerated page matched 35ed524, the hand fix, byte for byte. At the tip it sayspage-changed=falseand commits nothing.Not proven: the redeploy itself. It only runs on a real publication or a manual
deploy-mip-index-to-pagesdispatch. The first publication after both PRs merge is the test. Look for a second Pages deployment in that run and the new version on the page.