Repository navigation
firmware flash: take the chip from the image when no board is given - #74
Merged
Merged
Conversation
…names the chip and so the offset
bdbarnett
added a commit
that referenced
this pull request
Oct 6, 2026
…heading All ten version declarations now say 0.0.12 and check_versions.py passes. The bot's commit line becomes a written v0.0.12 entry for #74.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mpftp firmware flash --port esp32 --artifact <P4 firmware.bin>with no--boardor--familywrote the image at 0x0. A P4's bootloader belongs at 0x2000, so the DEV-KIT went into a reset loop. Windows dinged on every re-enumeration until it was reflashed with--offset 0x2000.A combined firmware.bin starts with the bootloader's image header, which carries the chip ID at byte 12. When neither a board nor a family is given,
flash_esp32now reads the family from there, so the offset comes out right for every chip in the table.--offset,--familyand--boardstill win.The new test plants the P4 image with no board. It passes here and fails against the old
flash_esp32. The rest oftest_app_image_offset.pystill passes.