Repository navigation
The editor takes env_set from boarddev (lands with the engine rebuild) - #23
Merged
Merged
Conversation
pydevices moved the env helpers from displaydev to boarddev with no re-export (a hard break). The engine freezes pydevices, so this lands with the engine rebuild that freezes the new pydevices, not before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyDevices/pydevices#131 moves the env helpers from displaydev to boarddev as a hard break. The editor now sets
MULTIMER_BACKENDwithboarddev.env_set.Don't merge this on its own. The engine is built with
build_mp.py --modules ...,pydevices,..., so pydevices is frozen into it, and the current engine's boarddev has noenv_set. Merge it with the engine rebuild that freezes #131's pydevices (the vst3 sidecar engine is prebuilt, and the installed bundle goes stale silently). Until then the current engine and the current editor agree.Not run: there's no engine with the new pydevices yet.