mip-split: the new multimer host-only modules (fixes the 0.6.0 MIP sync) - #104
Merged
Merged
Conversation
… name exists v0.6.0's MIP sync refused the tag because [multimer] host-only still named the five backends the timing redesign removed. Fixes #103.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.6.0 reached TestPyPI and its GitHub Release, but the MIP index refused it:
[multimer] host-onlystill named the five backends #101 removed. This lists the new host-only modules instead:_inputhook,_src_native,_src_pending,_src_signaland_src_wasm. Boards keep the dispatcher,_hostloop,_repl,_ticks,_src_machine,_src_none,_src_asyncioand the asyncio loaders.Checked with the MIP sync's own
read_host_onlyandcheck_no_host_importsfrom .github'ssynchronize_mip_package.py: both pass, and planting a removed name fails with the same error the 0.6.0 run gave.A new test,
tests/test_mip_split.py, fails when mip-split.toml names a module that isn't under lib/, so this is caught in the PR next time instead of after tagging. It fails on main's current file and passes here.The MIP index needs a follow-up release to pick this up, because the v0.6.0 tag can't move.
Fixes #103.