fix(web): stop the sidebar update icon from rendering clipped - #282
Merged
Conversation
The update pill is a 32px inline-grid with overflow hidden. Its hidden nowrap label shares the single grid cell, so the track grew to the label width and the icon was centred in that oversized track, then clipped to a half circle. Pin the track to the pill width and let both items shrink. Also shrink the sidebar logo from 220px to 200px.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (99)
Comment |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
commit: |
The npm registry occasionally times out during pnpm audit, causing the Security audit required check to fail with ERR_SOCKET_TIMEOUT. Add fetch timeout (120s) and retry config (3 retries with 20–120s backoff) via npm_config env vars to make the step resilient to transient network issues.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inline-gridwithoverflow: hidden. The hiddennowraplabel shares the icon's grid cell, so the track grew to the label's width, the icon was centred in that oversized track, and the visible part was a clipped half green circle. The track is now pinned withgrid-template-columns: minmax(0, 1fr)and both items getmin-width: 0.dist-webbundle restaged.Test plan
app-shell-contracts.test.tsupdated: new guards for the grid track +min-width: 0, logo width pinned to 200px.pnpm run build:webSummary by CodeRabbit
Bug Fixes
Style
Chores